You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/11/19 18:01:34 UTC
svn commit: r1895180 - in /poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model: Comments.java CommentsTable.java
Author: fanningpj
Date: Fri Nov 19 18:01:34 2021
New Revision: 1895180
URL: http://svn.apache.org/viewvc?rev=1895180&view=rev
Log:
try to make CommentsTable more extensible
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/Comments.java
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/CommentsTable.java
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/Comments.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/Comments.java?rev=1895180&r1=1895179&r2=1895180&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/Comments.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/Comments.java Fri Nov 19 18:01:34 2021
@@ -16,8 +16,8 @@
==================================================================== */
package org.apache.poi.xssf.model;
+import org.apache.poi.ss.usermodel.ClientAnchor;
import org.apache.poi.ss.util.CellAddress;
-import org.apache.poi.xssf.usermodel.XSSFClientAnchor;
import org.apache.poi.xssf.usermodel.XSSFComment;
import org.apache.poi.xssf.usermodel.XSSFSheet;
@@ -84,7 +84,7 @@ public interface Comments {
* @return new XSSFComment
* @since POI 5.2.0
*/
- XSSFComment createNewComment(XSSFSheet sheet, XSSFClientAnchor clientAnchor);
+ XSSFComment createNewComment(XSSFSheet sheet, ClientAnchor clientAnchor);
/**
* Called after the reference is updated, so that
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/CommentsTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/CommentsTable.java?rev=1895180&r1=1895179&r2=1895180&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/CommentsTable.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/CommentsTable.java Fri Nov 19 18:01:34 2021
@@ -27,6 +27,7 @@ import java.util.Map;
import org.apache.poi.ooxml.POIXMLDocumentPart;
import org.apache.poi.openxml4j.opc.PackagePart;
+import org.apache.poi.ss.usermodel.ClientAnchor;
import org.apache.poi.ss.util.CellAddress;
import org.apache.poi.util.Internal;
import org.apache.poi.util.Removal;
@@ -256,10 +257,10 @@ public class CommentsTable extends POIXM
* @since POI 5.2.0
*/
@Override
- public XSSFComment createNewComment(XSSFSheet sheet, XSSFClientAnchor clientAnchor) {
+ public XSSFComment createNewComment(XSSFSheet sheet, ClientAnchor clientAnchor) {
XSSFVMLDrawing vml = sheet.getVMLDrawing(true);
com.microsoft.schemas.vml.CTShape vmlShape = vml.newCommentShape();
- if (clientAnchor.isSet()) {
+ if (clientAnchor instanceof XSSFClientAnchor && ((XSSFClientAnchor)clientAnchor).isSet()) {
// convert offsets from emus to pixels since we get a
// DrawingML-anchor
// but create a VML Drawing
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org