You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/04 09:31:29 UTC

[GitHub] xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186032008
 
 

 ##########
 File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperHandler.java
 ##########
 @@ -74,6 +83,7 @@ public void handle(Invocation invocation, AsyncResponse asyncResp) {
     HystrixObservable<Response> command = delegate.createBizkeeperCommand(invocation);
 
     Observable<Response> observable = command.toObservable();
+    eventAlarm(invocation);
 
 Review comment:
   yes，we can not know when will do the break action，the break action occurs in the hystrix code,so need this logic, every time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services