[jira] [Created] (CAMEL-21256) camel-github startingSha=last does not work with large history

["Chris Slater (Jira)" <ji...@apache.org>]

Chris Slater created CAMEL-21256:
------------------------------------

             Summary: camel-github startingSha=last does not work with large history
                 Key: CAMEL-21256
                 URL: https://issues.apache.org/jira/browse/CAMEL-21256
             Project: Camel
          Issue Type: Bug
          Components: camel-github
    Affects Versions: 4.8.0
            Reporter: Chris Slater


I encountered an issue using startingSha=last with a repository with a large history.  The last sha is not correctly resolved.   CAMEL-17473 did not resolve this issue.  I am putting together a pull request with a possible solution.

 

The following issues were discovered from real-world testing and a unit test:
 # it appears that the first commit returned from the GitHub API is the most recent and the sha from that should be used as the lastSha variable.
 # There is a threading issue where CommitConsumer.poll() can be called concurrently with CommitConsumer.doStart().  In some situations lastSha can be null in the poll() method, producing the same behavior as startingSha=beginning, which is undesired.

 

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)