You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/09/26 13:16:44 UTC
[GitHub] mdeuser commented on a change in pull request #372: Add confirm
mechanism when delete or update action
mdeuser commented on a change in pull request #372: Add confirm mechanism when delete or update action
URL: https://github.com/apache/incubator-openwhisk-cli/pull/372#discussion_r220556404
##########
File path: commands/flags.go
##########
@@ -69,20 +69,22 @@ type FlagsStruct struct {
}
property struct {
- cert bool
- key bool
- auth bool
- apihost bool
- apiversion bool
- namespace bool
- cliversion bool
- apibuild bool
- apibuildno bool
- insecure bool
- all bool
- apihostSet string
- apiversionSet string
- namespaceSet string
+ cert bool
+ key bool
+ auth bool
+ apihost bool
+ apiversion bool
+ namespace bool
+ promptOnChange bool
+ cliversion bool
+ apibuild bool
+ apibuildno bool
+ insecure bool
+ all bool
+ apihostSet string
+ apiversionSet string
+ namespaceSet string
+ promptOnChangeSet string
Review comment:
can this be a boolean flag? i.e. the present of `--confirm` (typical practice in other clis use `--force`) indicates the desire to override the confirmation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services