You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/02 03:35:42 UTC
[GitHub] [fineract] ptuomola opened a new pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
ptuomola opened a new pull request #965:
URL: https://github.com/apache/fineract/pull/965
## Description
Makes the OpenJPA Enhance builder to be a manually triggered external tool in Eclipse, rather than an automatically triggered builder
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-637267592
Build will likely fail here as in other recent PRs due to FINERACT-855 - please help us fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-638071346
@ptuomola can I ask, more out of curiosity, why you chose to move the `*.launch` from `fineract-provider/.externalToolBuilders/` out into `config/` and document manually importing it? The way it used to be, but just not `"incremental,auto,"` seemed.. very "smooth", and saves a user the _File->Import->Run/Debug->Launch Configurations_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-646983735
> Not sure if this change is needed afterall. I've been using the automatic builder for a while, and haven't had any major problems with it.
@ptuomola agreed, it seems to actually work not so bad for me as well, now. Do you want to just close this PR then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-637294040
This will have to be re-based after #968 for FINERACT-1016 for the build to pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-638033465
@vorburger - rebased. When you get a chance, can you check if this works for you and addresses the issue about frequent runs of enhance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-644515956
Not sure if this change is needed afterall. I've been using the automatic builder for a while, and haven't had any major problems with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-638140582
@vorburger For a project builder, you have to choose at least one of the options from: after a clean, during manual builds, during auto builds, during a clean. I thought choosing "during manual builds" should stop the repeated running and still allow the user to trigger this by doing a manual build.
But when I tried this, the behaviour seemed to be somewhat inconsistent and I wasn't able to find a way to consistently ensure the task was triggered when I wanted it to be. That's why I thought the easiest solution would be just to make it an external builder that you can trigger manually separately from the rest of the build.
But we can also try the option of sticking with a project builder on setting "manual" and seeing if it does consistently do what we expect...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #965: FINERACT-1015: Moving OpenJPA Enhance builder from automatic to manual
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #965:
URL: https://github.com/apache/fineract/pull/965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org