You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/07/15 10:37:07 UTC
[GitHub] zeppelin pull request #1192: Versioning/get note revision api
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1192
Versioning/get note revision api
### What is this PR for?
Adds websocket api for getting note revision.
### What type of PR is it?
Improvement | Feature
### Todos
* [x] - add backend websocket handle
* [x] - add frontend call
### What is the Jira issue?
[#1189](https://issues.apache.org/jira/browse/ZEPPELIN-1189)
### How should this be tested?
green CI (can be tested once frontend implemented)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin versioning/get-note-revision-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
----
commit 79f8ac9525fb2f58fbde43511e742f65f47bf36e
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T09:03:06Z
add getNoteRevision to front
commit 3783fc95439391125205c2393f10466088773561
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T09:12:26Z
receive ws NOTE_REVISION msg
commit d9751c3117c0171076d5232f62b46ea9dd50b1bb
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T10:05:54Z
add backend ws api to get note revision
commit baaa704fbf9ba24db09ef631a4ef2ceb32809396
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T10:32:33Z
change NotebookRepo api to get note revision from Revision object to String revId
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1192
@bzz addressed the changes and CI is green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1192
Looks great to me! Thank you for taking care. Megin if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1192
Sounds great, thank you for taking care!
CI is still failing though :\ Please feel free to followup the failure here and I will be happy to help, if needed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1192
Looks like CI fails, could you please followup on the reason?
One more question - it looks like this PR not only add websocket API but change backend API and modify every NotebookRrpo implementation.
Is there a way to avoid such changes in a single PR? Or is there a strong reason for breaking API here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1192
[ZEPPELIN-1189] Get note revision websocket api
### What is this PR for?
Adds websocket api for getting note revision.
### What type of PR is it?
Improvement | Feature
### Todos
* [x] - add backend websocket handle
* [x] - add frontend call
### What is the Jira issue?
[#1189](https://issues.apache.org/jira/browse/ZEPPELIN-1189)
### How should this be tested?
green CI (can be tested once frontend implemented)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin versioning/get-note-revision-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
----
commit 79f8ac9525fb2f58fbde43511e742f65f47bf36e
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T09:03:06Z
add getNoteRevision to front
commit 3783fc95439391125205c2393f10466088773561
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T09:12:26Z
receive ws NOTE_REVISION msg
commit d9751c3117c0171076d5232f62b46ea9dd50b1bb
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T10:05:54Z
add backend ws api to get note revision
commit baaa704fbf9ba24db09ef631a4ef2ceb32809396
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T10:32:33Z
change NotebookRepo api to get note revision from Revision object to String revId
commit ce097ede81030da9273fea7b82dc38995d380e68
Author: Khalid Huseynov <kh...@khalids-macbook-pro.local>
Date: 2016-07-18T12:39:14Z
add throws to notebook getRevisionNote
commit aa0a7d6af3655b7205c2e1ecb15733e90aff69a2
Author: Khalid Huseynov <kh...@khalids-macbook-pro.local>
Date: 2016-07-18T16:24:05Z
Revert "change NotebookRepo api to get note revision from Revision object to String revId"
This reverts commit baaa704fbf9ba24db09ef631a4ef2ceb32809396.
commit 683b481ddcf754eb81c041189a207625921eb1f2
Author: Khalid Huseynov <kh...@khalids-macbook-pro.local>
Date: 2016-07-18T16:45:41Z
receive Revision object from frontend
instead of revisionId string
commit f1ab9948c918bf921827fa90e558c57d9a9458f8
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-07-19T14:09:42Z
Merge branch 'master' into versioning/get-note-revision-api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1192
@bzz fixed the issue with CI.
regarding change in api, you're right. it's better not to change api as a part of different PR, so I reverted it back. The main point in changing `Revision` object into just `String` representing `revisionId` was that `revisionId` can completely represent `Revision` object. However we don't need to address it right now, and it can be addressed as an improvement with addressing `pros` and `cons`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1192
[ZEPPELIN-1189] Get note revision websocket api
### What is this PR for?
Adds websocket api for getting note revision.
### What type of PR is it?
Improvement | Feature
### Todos
* [x] - add backend websocket handle
* [x] - add frontend call
### What is the Jira issue?
[#1189](https://issues.apache.org/jira/browse/ZEPPELIN-1189)
### How should this be tested?
green CI (can be tested once frontend implemented)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin versioning/get-note-revision-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
----
commit 79f8ac9525fb2f58fbde43511e742f65f47bf36e
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T09:03:06Z
add getNoteRevision to front
commit 3783fc95439391125205c2393f10466088773561
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T09:12:26Z
receive ws NOTE_REVISION msg
commit d9751c3117c0171076d5232f62b46ea9dd50b1bb
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T10:05:54Z
add backend ws api to get note revision
commit baaa704fbf9ba24db09ef631a4ef2ceb32809396
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-15T10:32:33Z
change NotebookRepo api to get note revision from Revision object to String revId
commit ce097ede81030da9273fea7b82dc38995d380e68
Author: Khalid Huseynov <kh...@khalids-macbook-pro.local>
Date: 2016-07-18T12:39:14Z
add throws to notebook getRevisionNote
commit aa0a7d6af3655b7205c2e1ecb15733e90aff69a2
Author: Khalid Huseynov <kh...@khalids-macbook-pro.local>
Date: 2016-07-18T16:24:05Z
Revert "change NotebookRepo api to get note revision from Revision object to String revId"
This reverts commit baaa704fbf9ba24db09ef631a4ef2ceb32809396.
commit 683b481ddcf754eb81c041189a207625921eb1f2
Author: Khalid Huseynov <kh...@khalids-macbook-pro.local>
Date: 2016-07-18T16:45:41Z
receive Revision object from frontend
instead of revisionId string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---