You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2020/03/19 18:07:08 UTC
[GitHub] [incubator-annotator] BigBlueHat opened a new pull request #66:
Improve licensing
BigBlueHat opened a new pull request #66: Improve licensing
URL: https://github.com/apache/incubator-annotator/pull/66
Fix #63
This *should* be what's needed to properly record the licensing on the `fragement.pegjs` and the generated (and potentially bundled?) `fragment.js` file.
Actions:
- added [W3C Software and and Document License](https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document) text to LICENSE and called out the above files (which this license covers)
- left the related notice content in NOTICE (per the W3C's license...and just for added clarity)
- added [the license and author declaration comments from the original generated `fragment.js`](https://github.com/w3c/web-annotation/blob/gh-pages/selector-note/converter/fragment.js#L1-L2) to our copy of `fragment.pegjs` (which is the source file)
Apache Rat still complains that this W3C license is not yet approved...
> Files with unapproved licenses:
> ./packages/dom/src/highlight-range.js
> ./packages/fragment-identifier/src/fragment.pegjs
Help wanted. 😁
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [incubator-annotator] BigBlueHat opened a new pull
request #66: Improve licensing
Posted by Nick Kew <ni...@apache.org>.
On Thu, 19 Mar 2020 18:07:08 -0000
GitBox <gi...@apache.org> wrote:
> BigBlueHat opened a new pull request #66: Improve licensing
> URL: https://github.com/apache/incubator-annotator/pull/66
>
>
> Fix #63
>
> This *should* be what's needed to properly record the licensing on
> the `fragement.pegjs` and the generated (and potentially bundled?)
> `fragment.js` file.
Is that where the problem lay? I hope we're not treating a
generated file as a source file?
> Actions:
> - added [W3C Software and and Document
> License](https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document)
> text to LICENSE and called out the above files (which this license
> covers)
Um, that looks literal. Doing anything to LICENSE is absolutely
not what's needed here!
> - left the related notice content in NOTICE (per the W3C's
> license...and just for added clarity)
> - added [the license and author declaration comments from the
> original generated
> `fragment.js`](https://github.com/w3c/web-annotation/blob/gh-pages/selector-note/converter/fragment.js#L1-L2)
> to our copy of `fragment.pegjs` (which is the source file) Apache Rat
> still complains that this W3C license is not yet approved...
That looks more likely to be the underlying issue. Can you
elaborate on "still complains"?
> > Files with unapproved licenses:
> > ./packages/dom/src/highlight-range.js
> > ./packages/fragment-identifier/src/fragment.pegjs
I think what Justin was looking for was a disclaimer about this
being work in progress with such issues still to be sorted.
https://www.mail-archive.com/general@incubator.apache.org/msg69806.html
--
Nick Kew
[GitHub] [incubator-annotator] tilgovi commented on a change in pull request
#66: Improve licensing
Posted by GitBox <gi...@apache.org>.
tilgovi commented on a change in pull request #66: Improve licensing
URL: https://github.com/apache/incubator-annotator/pull/66#discussion_r399692996
##########
File path: README.md
##########
@@ -55,6 +55,17 @@ $ yarn start
Once the test server has started, you can browse a local demo, and run tests in
a browser by visiting `http://localhost:8080/`.
+##### Validate Licensing
+
+[Apache Rat (Release Audit Tool)](https://creadur.apache.org/rat/) is a
+preferred code license checking tool used by [the ASF](https://apache.org/).
+The included `.ratignore` file contains a list of files to exclude from scans.
+
+To check for included licenses, run the following and view the output report:
+```sh
+java -jar ~/bin/apache-rat-0.13/apache-rat-0.13.jar -E .ratignore -d . > rat_report.txt
+```
+
Review comment:
What do you think about moving this later in the README? Some users may care, but I would guess most would not need to see this first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] tilgovi commented on a change in pull request
#66: Improve licensing
Posted by GitBox <gi...@apache.org>.
tilgovi commented on a change in pull request #66: Improve licensing
URL: https://github.com/apache/incubator-annotator/pull/66#discussion_r399693024
##########
File path: README.md
##########
@@ -55,6 +55,17 @@ $ yarn start
Once the test server has started, you can browse a local demo, and run tests in
a browser by visiting `http://localhost:8080/`.
+##### Validate Licensing
+
+[Apache Rat (Release Audit Tool)](https://creadur.apache.org/rat/) is a
+preferred code license checking tool used by [the ASF](https://apache.org/).
+The included `.ratignore` file contains a list of files to exclude from scans.
+
+To check for included licenses, run the following and view the output report:
+```sh
+java -jar ~/bin/apache-rat-0.13/apache-rat-0.13.jar -E .ratignore -d . > rat_report.txt
+```
+
Review comment:
Perhaps as a subheading under our License section, below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] tilgovi closed pull request #66: Improve
licensing
Posted by GitBox <gi...@apache.org>.
tilgovi closed pull request #66: Improve licensing
URL: https://github.com/apache/incubator-annotator/pull/66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] tilgovi commented on a change in pull request
#66: Improve licensing
Posted by GitBox <gi...@apache.org>.
tilgovi commented on a change in pull request #66: Improve licensing
URL: https://github.com/apache/incubator-annotator/pull/66#discussion_r399691949
##########
File path: LICENSE
##########
@@ -200,3 +200,48 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+
+---
+
+
+For the packages/fragment-identifier/src/fragment.js and
+packages/fragment-identifier/src/fragment.pegjs components from
Review comment:
`fragment.js` is not included in the source release. I think it makes sense to have it in the `.ratignore`, just to avoid confusion for anyone who runs the tool against a dirty project directory, but i doesn't make sense to list here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services