[GitHub] [arrow] westonpace commented on pull request #34008: GH-34007: [C++] Add an array_span_mutable interface to ExecResult

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on PR #34008:
URL: https://github.com/apache/arrow/pull/34008#issuecomment-1414522524

   +1 on the idea of `array_span_mutable`.
   
   I'm -0.5 on rewriting everything to auto.  Arrow follows the [google C++ style guide](https://google.github.io/styleguide/cppguide.html#Type_deduction) which states:
   
   > The fundamental rule is: use type deduction only to make the code clearer or safer, and do not use it merely to avoid the inconvenience of writing an explicit type. When judging whether the code is clearer, keep in mind that your readers are not necessarily on your team, or familiar with your project, so types that you and your reviewer experience as unnecessary clutter will very often provide useful information to others. For example, you can assume that the return type of make_unique<Foo>() is obvious, but the return type of MyWidgetFactory() probably isn't.
   
   Though that leaves plenty of room for interpretation.  We also have not applied the rule consistently and large chunks of the code base use auto extensively.
   
   However, I would generally discourage rewriting something to auto just because you can.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org