[GitHub] [tomcat] markt-asf commented on issue #139: service.bat handles changed Service at installation

[GitBox <gi...@apache.org>]

markt-asf commented on issue #139: service.bat handles changed Service at installation
URL: https://github.com/apache/tomcat/pull/139#issuecomment-515918939
 
 
   I started to implement the above suggestion and hit another issue. If you install via the installer with a non-standard name you can;t rename the service because the .exe files have been renamed.
   
   Having looked at various options I think the best option is as follows:
   - leave the installer as is
   - require the service name to be provided unless the default name is used
   - rename .exe files when installing non-default service name from batch file (to align with installer behaviour)
   - rename .exe files to defaults when uninstalling non-default service name from batch file (to allow subsequent installations to use any valid service name)
   
   These last two points are the main change. Unless there are objections, I'll proceed on this basis later this week.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org