[GitHub] [arrow] jonkeane commented on a diff in pull request #13289: ARROW-14632: [Python] Make write_dataset arguments keyword-only

[GitBox <gi...@apache.org>]

jonkeane commented on code in PR #13289:
URL: https://github.com/apache/arrow/pull/13289#discussion_r887199144


##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -1796,6 +1796,12 @@ def test_dictionary_partitioning_outer_nulls_raises(tempdir):
         ds.write_dataset(table, tempdir, format='ipc', partitioning=part)
 
 
+def test_positional_keywords_raises(tempdir):
+    table = pa.table({'a': ['x', 'y', None], 'b': ['x', 'y', 'z']})
+    with pytest.raises(TypeError):
+        ds.write_dataset(table, tempdir, "basename-{i}.parquet")

Review Comment:
   This is minor, but we might want to not use `.parquet` in the basename template so as not to confuse why this isn't being guarded by `@pytest.mark.parquet` below. `ipc` or `arrow` would be better IMO
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org