You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/04/05 19:44:07 UTC

Review Request: Added another Cluster::Slaves::start.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10308/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Description
-------

See summary.


Diffs
-----

  src/tests/cluster.hpp 7cc97518120dfa9b5e82826ed0240e57a28be4c2 

Diff: https://reviews.apache.org/r/10308/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request: Added another Cluster::Slaves::start.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10308/#review18771
-----------------------------------------------------------



src/tests/cluster.hpp
<https://reviews.apache.org/r/10308/#comment39185>

    Need a comment here about the ownership of the allocatorProcess.



src/tests/cluster.hpp
<https://reviews.apache.org/r/10308/#comment39186>

    ditto..w.r.t. executor



src/tests/cluster.hpp
<https://reviews.apache.org/r/10308/#comment39187>

    ditto.



src/tests/cluster.hpp
<https://reviews.apache.org/r/10308/#comment39188>

    ditto.



src/tests/cluster.hpp
<https://reviews.apache.org/r/10308/#comment39189>

    ditto.


- Vinod Kone


On April 5, 2013, 5:44 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10308/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 5:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp 7cc97518120dfa9b5e82826ed0240e57a28be4c2 
> 
> Diff: https://reviews.apache.org/r/10308/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>