[GitHub] [skywalking-data-collect-protocol] wu-sheng opened a new pull request, #77: Support SpanAttachedEvent

[GitBox <gi...@apache.org>]

wu-sheng opened a new pull request, #77:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/77

   FYI @apache/skywalking-committers 
   
   This is a new extension and the first one after [Trace Data Protocol v3](https://skywalking.apache.org/docs/main/next/en/protocols/trace-data-protocol-v3/). So I marked this as v3.1, the main document would be updated once this is really implemented.
   
   ## Case Scenario
   When an RPC is being traced by the in-process language agent, a span would be reported by the client-side agent.
   And the rover would be aware of this RPC due to the existing tracing header.
   Then, the rover agent collects extra information from the OS level to provide assistance information to diagnose network performance.
   
   ## Who is going to implement this
   The Rover(ebpf) agent would implement this. This relies on the rover agent having the capability to decode HTTP(at least) header and body on the fly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #77: Support SpanAttachedEvent

[GitBox <gi...@apache.org>]

wu-sheng merged PR #77:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a diff in pull request #77: Support SpanAttachedEvent

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #77:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/77#discussion_r994605353


##########
common/Common.proto:
##########
@@ -52,3 +59,16 @@ message Command {
     repeated KeyStringValuePair args = 2;
 }
 
+// since v3.1
+// An instantaneous point on the time-line.
+// An instance represents a data point accurate to the nanosecond.

Review Comment:
   ```suggestion
   // An instant represents a data point accurate to the nanosecond.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org