[GitHub] [incubator-nuttx] patacongo opened a new pull request #645: "Uninterruptible" semaphore waits must return when canceled.

[GitBox <gi...@apache.org>]

patacongo opened a new pull request #645: "Uninterruptible" semaphore waits must return when canceled.
URL: https://github.com/apache/incubator-nuttx/pull/645
 
 
   nxsem_timedwait_uninterruptible() and nxsem_tickwait_uninterruptible() must return -ECANCELED if the thread is canceled.  This change modifies the inline versions of the functions in included/nuttx/semaphore.h as well as the fallback, non-inlined versions in sched/semaphore/sem_timedwait.c and sem_tickwaith.c.
   
   Also modified were two files under drivers.  The modifications were necessary to assure that the drivers do the right thing is ECANCELED is returned.
   
   This is part of the fix to issue #619 . The full solution will require similar modificatinos to nxsem_wait_uninterruptible().  That, however, is a much large effort because nxsem_wait_uninterruptible is used much more frequently, and also because the return value is usually ignored.  Those cases must all be changed to that they handle the -ECANCELED error return value.
   
   Even though there are many files, the change would still be rather easy if it were not for the fact that all of the modified files would also need to go throught nxstyle.  Most of the files requiring modificatin are under arch/ and those historically have more coding standard issues.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] acassis merged pull request #645: "Uninterruptible" semaphore waits must return when canceled.

[GitBox <gi...@apache.org>]

acassis merged pull request #645: "Uninterruptible" semaphore waits must return when canceled.
URL: https://github.com/apache/incubator-nuttx/pull/645
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services