You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Brian Carrier (JIRA)" <ji...@apache.org> on 2008/12/03 23:59:44 UTC

[jira] Created: (PDFBOX-394) TestFDF junit test failing in testFDFFreedomExpressions().

TestFDF junit test failing in testFDFFreedomExpressions().
----------------------------------------------------------

                 Key: PDFBOX-394
                 URL: https://issues.apache.org/jira/browse/PDFBOX-394
             Project: PDFBox
          Issue Type: Test
          Components: Parsing
    Affects Versions: 0.8.0-incubator
            Reporter: Brian Carrier


Currently, the TestFDF junit tests are failing because testFDFFreedomExpressions() tries to load an FDF file and PDFParser.parseHeader() returns an error because it can't find a PDF header.  I fixed that code so that it also looks for an FDF header. That patch is attached. 

However, it still results in a test failure with this line:

assertTrue( totalAmt.getDictionary().getDictionaryObject( "AP" ) == null );

I haven't looked at the test file enough to determine where the problem is. getDictionaryObject("AP") is returning a COSDictionary. PDFDebugger shows that eeSuppTotalAmt is in entry 58, but I don't see any obvious reference to an "AP". 

Also, TestFDF is being called twice in TestAll.java. That patch is also attached.

Please apply these patches and keep this open so that the assertion failure can be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-394) TestFDF junit test failing in testFDFFreedomExpressions().

Posted by "Brian Carrier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672777#action_12672777 ] 

Brian Carrier commented on PDFBOX-394:
--------------------------------------

These two diffs were checked in.

Sending        trunk/src/main/java/org/apache/pdfbox/pdfparser/PDFParser.java
Sending        trunk/src/test/java/org/apache/pdfbox/TestAll.java
Transmitting file data ..
Committed revision 743506.

As mentioned in the first comment, this test still fails though with the "AP" object. 

> TestFDF junit test failing in testFDFFreedomExpressions().
> ----------------------------------------------------------
>
>                 Key: PDFBOX-394
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-394
>             Project: PDFBox
>          Issue Type: Test
>          Components: Parsing
>    Affects Versions: 0.8.0-incubator
>            Reporter: Brian Carrier
>         Attachments: PDFParser.diff, TestAll.diff
>
>
> Currently, the TestFDF junit tests are failing because testFDFFreedomExpressions() tries to load an FDF file and PDFParser.parseHeader() returns an error because it can't find a PDF header.  I fixed that code so that it also looks for an FDF header. That patch is attached. 
> However, it still results in a test failure with this line:
> assertTrue( totalAmt.getDictionary().getDictionaryObject( "AP" ) == null );
> I haven't looked at the test file enough to determine where the problem is. getDictionaryObject("AP") is returning a COSDictionary. PDFDebugger shows that eeSuppTotalAmt is in entry 58, but I don't see any obvious reference to an "AP". 
> Also, TestFDF is being called twice in TestAll.java. That patch is also attached.
> Please apply these patches and keep this open so that the assertion failure can be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PDFBOX-394) TestFDF junit test failing in testFDFFreedomExpressions().

Posted by "Brian Carrier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Carrier updated PDFBOX-394:
---------------------------------

    Attachment: PDFParser.diff
                TestAll.diff

Patches that fix some of the problems in the TestFDF junit test. 

> TestFDF junit test failing in testFDFFreedomExpressions().
> ----------------------------------------------------------
>
>                 Key: PDFBOX-394
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-394
>             Project: PDFBox
>          Issue Type: Test
>          Components: Parsing
>    Affects Versions: 0.8.0-incubator
>            Reporter: Brian Carrier
>         Attachments: PDFParser.diff, TestAll.diff
>
>
> Currently, the TestFDF junit tests are failing because testFDFFreedomExpressions() tries to load an FDF file and PDFParser.parseHeader() returns an error because it can't find a PDF header.  I fixed that code so that it also looks for an FDF header. That patch is attached. 
> However, it still results in a test failure with this line:
> assertTrue( totalAmt.getDictionary().getDictionaryObject( "AP" ) == null );
> I haven't looked at the test file enough to determine where the problem is. getDictionaryObject("AP") is returning a COSDictionary. PDFDebugger shows that eeSuppTotalAmt is in entry 58, but I don't see any obvious reference to an "AP". 
> Also, TestFDF is being called twice in TestAll.java. That patch is also attached.
> Please apply these patches and keep this open so that the assertion failure can be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.