[GitHub] [solr] dsmiley commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #604:
URL: https://github.com/apache/solr/pull/604#discussion_r801090172



##########
File path: solr/modules/gcs-repository/build.gradle
##########
@@ -55,6 +59,9 @@ dependencies {
     implementation('io.opencensus:opencensus-api') { transitive = false }
     implementation('io.opencensus:opencensus-contrib-http-util') { exclude group: 'com.google.guava', module: 'guava' }
 
-    testImplementation("com.google.cloud:google-cloud-nio") { exclude group: 'com.google.guava', module: 'guava' }
     testImplementation project(':solr:test-framework')
+    testImplementation 'org.apache.lucene:lucene-test-framework'
+    testImplementation 'com.carrotsearch.randomizedtesting:randomizedtesting-runner'
+    testImplementation 'junit:junit'
+    testImplementation("com.google.cloud:google-cloud-nio") { exclude group: 'com.google.guava', module: 'guava' }

Review comment:
       Maybe we can remove this exclusion?  Or perhaps that Guava is newer so we can't.

##########
File path: solr/modules/analysis-extras/build.gradle
##########
@@ -15,25 +15,33 @@
  * limitations under the License.
  */
 
-
 apply plugin: 'java-library'
 
 description = 'Additional analysis components'
 
 dependencies {
   api project(':solr:core')
 
+  implementation project(':solr:solrj')
+
   implementation 'commons-io:commons-io'
-  implementation "org.apache.lucene:lucene-analysis-icu"
-  implementation "org.apache.lucene:lucene-analysis-smartcn"
-  implementation "org.apache.lucene:lucene-analysis-morfologik"
-  implementation "org.apache.lucene:lucene-analysis-opennlp"
-  implementation "org.apache.lucene:lucene-analysis-smartcn"
-  implementation "org.apache.lucene:lucene-analysis-stempel"
+  implementation 'com.ibm.icu:icu4j'
+  implementation 'org.apache.lucene:lucene-analysis-icu'
+  implementation 'org.apache.lucene:lucene-analysis-smartcn'
+  implementation 'org.apache.lucene:lucene-analysis-morfologik'
+  implementation 'org.apache.lucene:lucene-analysis-opennlp'
+  implementation 'org.apache.lucene:lucene-analysis-smartcn'
+  implementation 'org.apache.lucene:lucene-analysis-stempel'
+  implementation 'org.apache.lucene:lucene-core'
+  implementation 'org.apache.opennlp:opennlp-tools'
+  implementation 'org.slf4j:slf4j-api'
 
   testImplementation project(':solr:test-framework')
+  testImplementation 'org.apache.lucene:lucene-analysis-common'
+  testImplementation 'junit:junit'
   testImplementation('org.mockito:mockito-core', {
     exclude group: "net.bytebuddy", module: "byte-buddy-agent"
   })
-  testImplementation('org.apache.logging.log4j:log4j-core')
+  testImplementation 'org.apache.logging.log4j:log4j-api'

Review comment:
       Maybe out of scope but Hoss recently added a cool utility that could be used here: SOLR-15807: New LogListener




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org