You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2009/03/19 00:41:04 UTC
svn commit: r755784 - in
/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http:
auth/params/AuthParams.java conn/params/ConnManagerParams.java
conn/params/ConnRouteParams.java conn/routing/BasicRouteDirector.java
Author: sebb
Date: Wed Mar 18 23:41:04 2009
New Revision: 755784
URL: http://svn.apache.org/viewvc?rev=755784&view=rev
Log:
Some more immutable classes
Modified:
httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/auth/params/AuthParams.java
httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnManagerParams.java
httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnRouteParams.java
httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/routing/BasicRouteDirector.java
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/auth/params/AuthParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/auth/params/AuthParams.java?rev=755784&r1=755783&r2=755784&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/auth/params/AuthParams.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/auth/params/AuthParams.java Wed Mar 18 23:41:04 2009
@@ -31,6 +31,8 @@
package org.apache.http.auth.params;
+import net.jcip.annotations.Immutable;
+
import org.apache.http.params.HttpParams;
import org.apache.http.protocol.HTTP;
@@ -45,6 +47,7 @@
*
* @see AuthPNames
*/
+@Immutable
public final class AuthParams {
private AuthParams() {
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnManagerParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnManagerParams.java?rev=755784&r1=755783&r2=755784&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnManagerParams.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnManagerParams.java Wed Mar 18 23:41:04 2009
@@ -30,6 +30,8 @@
package org.apache.http.conn.params;
+import net.jcip.annotations.Immutable;
+
import org.apache.http.conn.routing.HttpRoute;
import org.apache.http.params.HttpParams;
@@ -45,6 +47,7 @@
*
* @see ConnManagerPNames
*/
+@Immutable
public final class ConnManagerParams implements ConnManagerPNames {
/** The default maximum number of connections allowed overall */
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnRouteParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnRouteParams.java?rev=755784&r1=755783&r2=755784&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnRouteParams.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/params/ConnRouteParams.java Wed Mar 18 23:41:04 2009
@@ -33,6 +33,8 @@
import java.net.InetAddress;
+import net.jcip.annotations.Immutable;
+
import org.apache.http.HttpHost;
import org.apache.http.params.HttpParams;
import org.apache.http.conn.routing.HttpRoute;
@@ -48,6 +50,7 @@
*
* @since 4.0
*/
+@Immutable
public class ConnRouteParams implements ConnRoutePNames {
/**
@@ -56,13 +59,13 @@
* with actual hosts. Note that this is a <i>valid</i> host.
*/
public static final HttpHost NO_HOST =
- new HttpHost("127.0.0.255", 0, "no-host");
+ new HttpHost("127.0.0.255", 0, "no-host"); // Immutable
/**
* A special value indicating "no route".
* This is a route with {@link #NO_HOST} as the target.
*/
- public static final HttpRoute NO_ROUTE = new HttpRoute(NO_HOST);
+ public static final HttpRoute NO_ROUTE = new HttpRoute(NO_HOST); // Immutable
/** Disabled default constructor. */
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/routing/BasicRouteDirector.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/routing/BasicRouteDirector.java?rev=755784&r1=755783&r2=755784&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/routing/BasicRouteDirector.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/routing/BasicRouteDirector.java Wed Mar 18 23:41:04 2009
@@ -31,6 +31,7 @@
package org.apache.http.conn.routing;
+import net.jcip.annotations.Immutable;
/**
@@ -44,6 +45,7 @@
*
* @since 4.0
*/
+@Immutable
public class BasicRouteDirector implements HttpRouteDirector {
// public default constructor