You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "alexandrusoare (via GitHub)" <gi...@apache.org> on 2026/08/26 11:59:59 UTC
[PR] feat(reports): gate retry functionality behind ALERT_REPORTS_RETRY flag [superset]
alexandrusoare opened a new pull request, #43553:
URL: https://github.com/apache/superset/pull/43553
### SUMMARY
- Places the report retry feature behind a new ALERT_REPORTS_RETRY feature flag, defaulting to False
- When the flag is off: retry UI is hidden, retry fields are stripped from API writes, and _handle_retry_or_error is a no-op
- When the flag is on: full retry functionality works as implemented
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(reports): gate retry functionality behind ALERT_REPORTS_RETRY flag [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43553:
URL: https://github.com/apache/superset/pull/43553#issuecomment-5424945898
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(reports): gate retry functionality behind ALERT_REPORTS_RETRY flag [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43553:
URL: https://github.com/apache/superset/pull/43553#issuecomment-5425001237
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43553?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.47%. Comparing base ([`e7ca8b8`](https://app.codecov.io/gh/apache/superset/commit/e7ca8b8a5718b2b8e7e18a18338b3009c2e27247?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`081950e`](https://app.codecov.io/gh/apache/superset/commit/081950ea4bb1c4b7e32b42f979a6410fb07e3ec1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43553?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/commands/report/update.py](https://app.codecov.io/gh/apache/superset/pull/43553?src=pr&el=tree&filepath=superset%2Fcommands%2Freport%2Fupdate.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvcmVwb3J0L3VwZGF0ZS5weQ==) | 9.09% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/reports/schemas.py](https://app.codecov.io/gh/apache/superset/pull/43553?src=pr&el=tree&filepath=superset%2Freports%2Fschemas.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | 37.50% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/commands/report/execute.py](https://app.codecov.io/gh/apache/superset/pull/43553?src=pr&el=tree&filepath=superset%2Fcommands%2Freport%2Fexecute.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvcmVwb3J0L2V4ZWN1dGUucHk=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43553 +/- ##
===========================================
- Coverage 79.08% 57.47% -21.62%
===========================================
Files 2877 2877
Lines 165451 165466 +15
Branches 38235 38239 +4
===========================================
- Hits 130849 95097 -35752
- Misses 32121 69474 +37353
+ Partials 2481 895 -1586
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43553/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/43553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <21.21%> (-0.01%)` | :arrow_down: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/43553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/43553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/43553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.90% <21.21%> (-0.01%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/43553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.96% <21.21%> (-43.70%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/43553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/43553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43553?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(reports): gate retry functionality behind ALERT_REPORTS_RETRY flag [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43553:
URL: https://github.com/apache/superset/pull/43553#issuecomment-5424964375
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 081950ea4bb1c4b7e32b42f979a6410fb07e3ec1 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a8ed53f5b3ba10008e2c77f |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43553--superset-docs-preview.netlify.app](https://deploy-preview-43553--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#FctBCoMwFEXRvfyxwbRile6gy_gxL3WQmvAaQRH3bpxdLpxDMtMvF3mLNOKoyzTX1ohNF8_1n5RoA7S0RE4shijczX1WwoSo3wo9ckz7x1f60hG-70LvOqcPa-2I5zQMQc4L) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43553--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(reports): gate retry functionality behind ALERT_REPORTS_RETRY flag [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43553:
URL: https://github.com/apache/superset/pull/43553#discussion_r3863099780
##########
superset/reports/schemas.py:
##########
@@ -180,7 +189,31 @@ def validate_addresses(field: str, value: str | None, required: bool) -> None:
validate_addresses("bccTarget", config.get("bccTarget"), required=False)
-class ReportSchedulePostSchema(Schema):
+_RETRY_FIELD_KEYS = (
+ "retry_on_failure",
+ "retry_max_attempts",
+ "send_failed_reports",
+ "retry_notify_owners",
+ "retry_notify_recipients",
+)
+
+
+class RetryFieldStripMixin:
+ """Strip retry fields from the deserialized payload when the feature is off."""
+
+ @post_load
+ def strip_retry_fields_if_disabled(
+ self,
+ data: dict[str, Any],
+ **kwargs: Any,
+ ) -> dict[str, Any]:
+ if not is_feature_enabled("ALERT_REPORTS_RETRY"):
+ for key in _RETRY_FIELD_KEYS:
+ data.pop(key, None)
+ return data
Review Comment:
**Suggestion:** The retry fields are removed in a `post_load` hook, but Marshmallow runs field and schema validation before `post_load`. With `ALERT_REPORTS_RETRY` disabled, payloads containing values such as `retry_max_attempts=0` or `retry_max_attempts=11` still fail validation instead of being ignored and stripped as intended. Strip or bypass these fields before validation, or conditionally disable their validators when the feature flag is off. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Report schedule POST/PUT writes reject disabled retry fields.
- ⚠️ External API clients cannot rely on disabled fields being ignored.
- ⚠️ Feature-flag rollout can produce unexpected validation failures.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3fede4fd705444c18366872c9e4a9fd6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3fede4fd705444c18366872c9e4a9fd6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/reports/schemas.py
**Line:** 201:213
**Comment:**
*Api Mismatch: The retry fields are removed in a `post_load` hook, but Marshmallow runs field and schema validation before `post_load`. With `ALERT_REPORTS_RETRY` disabled, payloads containing values such as `retry_max_attempts=0` or `retry_max_attempts=11` still fail validation instead of being ignored and stripped as intended. Strip or bypass these fields before validation, or conditionally disable their validators when the feature flag is off.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43553&comment_hash=d4dfb6e1df9d6b3714197170287d0c80f633465ac8de916c074b563815f9ba78&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43553&comment_hash=d4dfb6e1df9d6b3714197170287d0c80f633465ac8de916c074b563815f9ba78&reaction=dislike'>👎</a>
##########
superset/commands/report/execute.py:
##########
@@ -1767,7 +1771,8 @@ def next(self) -> None: # noqa: C901
return
self.send()
# Clear any retry state from previous failed attempts in this window.
- self._reset_retry_counter()
+ if feature_flag_manager.is_feature_enabled("ALERT_REPORTS_RETRY"):
+ self._reset_retry_counter()
Review Comment:
**Suggestion:** When the feature flag is disabled after a schedule has entered `RETRYING`, successful executions no longer clear `retry_attempt` or `retry_scheduled_dttm`. The schedule can therefore retain exhausted retry state while retries are disabled, and the stale counter may be reused when the flag is later enabled, causing the first subsequent failure to skip retries. Clear stale retry state whenever execution reaches a terminal success, regardless of whether retry handling is currently enabled. [stale reference]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Re-enabled schedules can skip their first retry.
- ⚠️ Runtime feature-flag changes leave inconsistent retry state.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=29e07ea6c6194040964bef6f4de1fd14&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=29e07ea6c6194040964bef6f4de1fd14&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 1774:1775
**Comment:**
*Stale Reference: When the feature flag is disabled after a schedule has entered `RETRYING`, successful executions no longer clear `retry_attempt` or `retry_scheduled_dttm`. The schedule can therefore retain exhausted retry state while retries are disabled, and the stale counter may be reused when the flag is later enabled, causing the first subsequent failure to skip retries. Clear stale retry state whenever execution reaches a terminal success, regardless of whether retry handling is currently enabled.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43553&comment_hash=d9f2dc672f9cc8a0be63e57ff89986904b8ff42c3da9bf5b8ef6ed337720fb52&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43553&comment_hash=d9f2dc672f9cc8a0be63e57ff89986904b8ff42c3da9bf5b8ef6ed337720fb52&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(reports): gate retry functionality behind ALERT_REPORTS_RETRY flag [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #43553:
URL: https://github.com/apache/superset/pull/43553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(reports): gate retry functionality behind ALERT_REPORTS_RETRY flag [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43553:
URL: https://github.com/apache/superset/pull/43553#issuecomment-5427546916
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(reports): gate retry functionality behind ALERT_REPORTS_RETRY flag [superset]
Posted by "alexandrusoare (via GitHub)" <gi...@apache.org>.
alexandrusoare commented on code in PR #43553:
URL: https://github.com/apache/superset/pull/43553#discussion_r3863487930
##########
superset/reports/schemas.py:
##########
@@ -180,7 +189,31 @@ def validate_addresses(field: str, value: str | None, required: bool) -> None:
validate_addresses("bccTarget", config.get("bccTarget"), required=False)
-class ReportSchedulePostSchema(Schema):
+_RETRY_FIELD_KEYS = (
+ "retry_on_failure",
+ "retry_max_attempts",
+ "send_failed_reports",
+ "retry_notify_owners",
+ "retry_notify_recipients",
+)
+
+
+class RetryFieldStripMixin:
+ """Strip retry fields from the deserialized payload when the feature is off."""
+
+ @post_load
+ def strip_retry_fields_if_disabled(
+ self,
+ data: dict[str, Any],
+ **kwargs: Any,
+ ) -> dict[str, Any]:
+ if not is_feature_enabled("ALERT_REPORTS_RETRY"):
+ for key in _RETRY_FIELD_KEYS:
+ data.pop(key, None)
+ return data
Review Comment:
Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org