You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/08/20 22:34:36 UTC
[GitHub] incubator-brooklyn pull request: Illustration and test for PlanToS...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/860
Illustration and test for PlanToSpecTransformer, and tidies
It's pretty straightforward to write a new plan-to-spec transformer. This paves the way for TOSCA support, among other things.
I wonder in time about this being bi-directional, i.e. also usable for persisting and rebinding.
/cc @aledsage @neykov
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn pluggable-plans
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/860.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #860
----
commit 2a3603ba19cc5551bfead2f04158e5f666431de7
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-08-20T20:31:35Z
Illustration and test for PlanToSpecTransformer which uses XML, and tidies encountered in the process
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Illustration and test for PlanToS...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/860#issuecomment-133163102
BTW @neykov @andreaturli excellent job on the original work; very easy to work with
Great to have CAMP entirely pluggable, through a tiny interface!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Illustration and test for PlanToS...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/860#issuecomment-133426655
Looks good - a nice improvement.
I don't see the value of using `attemptWithLoaders` vs passing the string directly, but it's just a personal preference (don't like the syntax overhead of anonymous classes).
Also the `OVERRIDE` test property is a bit smelly, but agree it's the best we can do without introducing even more abstraction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Illustration and test for PlanToS...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/860#issuecomment-133244780
There is no problem with this PR, that is a test issue that occurs rarely. I'll take a look at it.
Reviewed, tested, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Illustration and test for PlanToS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---