You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/13 07:17:07 UTC

[GitHub] [apisix] arthur-zhang edited a comment on pull request #5038: feat(hmac-auth): Add validate request body for hmac auth plugin

arthur-zhang edited a comment on pull request #5038:
URL: https://github.com/apache/apisix/pull/5038#issuecomment-917909479


   > hi @arthur-zhang, I notice this `当无请求 body 时，可不传 Digest 头部，网关会校验是否确实无请求 body。如果要传 Digest 头部，可计算长度为 0 的空字符串的 hmac-sha 值。`, should we add test cases about GET method?
   
   I Add test `=== TEST 4: missing digest header and body is empty` for post request without body, GET is no difference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org