You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/22 05:13:30 UTC

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #1710: feat: duplicate upstream service consumer

bzp2010 commented on a change in pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#discussion_r713595267



##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -88,6 +88,7 @@ export default {
   'page.upstream.list.edit.time': 'Updated At',
   'page.upstream.list.operation': 'Operation',
   'page.upstream.list.edit': 'Configure',
+  'page.upstream.list.duplicate': 'Duplicate',

Review comment:
       ```suggestion
   
   ```

##########
File path: web/src/pages/Upstream/locales/zh-CN.ts
##########
@@ -88,6 +88,7 @@ export default {
   'page.upstream.list.edit.time': '更新时间',
   'page.upstream.list.operation': '操作',
   'page.upstream.list.edit': '配置',
+  'page.upstream.list.duplicate': '复制',

Review comment:
       ```suggestion
   
   ```

##########
File path: web/src/pages/Upstream/List.tsx
##########
@@ -92,6 +92,12 @@ const Page: React.FC = () => {
           }}>
             {formatMessage({ id: 'component.global.view' })}
           </Button>
+          <Button
+            type="primary"
+            onClick={() => history.push(`/upstream/${record.id}/duplicate`)}
+          >
+            {formatMessage({ id: 'page.upstream.list.duplicate' })}

Review comment:
       ```suggestion
               {formatMessage({ id: 'component.global.duplicate' })}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org