Re: [PATCH]: Was [PROPOSAL] Takeover Take 2

[Julian Foad <ju...@btopenworld.com>]

Paul Burba wrote:
> Discussion of this patch fell by the wayside when I went on vacation.  I 
> believe this is ready to commit, but I wanted to check if anyone has any 
> outstanding concerns regarding it.  I'm in no major rush, but I'd like to 
> get it into trunk.

Hi Paul.  I think it's time you checked in this patch.  It's had ample time for 
review even though I still haven't got around to going through it as 
thouroughly as I would like to in an ideal world.  But it's not like you're a 
drive-by contributor: you're around to improve it later if people find things 
that need your input.  So just go for it.  Enough people agree the 
functionality is good, and any deficiencies that remain by now must be minor.

Some trivia I noticed:

   * main.c: Help text for "update" ends with a colon.

   * checkout_tests.py: whole content repeated in the patch file: take care 
when applying the patch in case the unversioned file already exists, and check 
you've "svn add"ed the file before committing.

   * checkout_tests.py: "'-m', 'Log message for new import'" is silly (I'd just 
write 'Import' or '').

   * checkout_tests.py: "Julian's scenario" -> proper brief description 
(something like "Ensure that an import followed by a checkout in place works 
perfectly")

   * Some spaces at end of lines (now we're talking Julian-level trivia)


> Julian - I know you wanted to see a new option used rather than --force, 
> but looking back in the takeover threads I don't see a firm consensus on 
> this.  If a new option is eventually what we decide on, I'll galdly change 
> it later.

I'm fine with putting it in as "--force" for now.  I'd rather like it if it 
could be renamed before it gets released, but that's for a separate discussion.

Thanks,

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH]: Was [PROPOSAL] Takeover Take 2

[Paul Burba <pa...@softlanding.com>]

Julian Foad <ju...@btopenworld.com> wrote on 08/01/2006 05:59:27 PM:

> Paul Burba wrote:
> > Discussion of this patch fell by the wayside when I went on vacation. 
I 
> > believe this is ready to commit, but I wanted to check if anyone has 
any 
> > outstanding concerns regarding it.  I'm in no major rush, but I'd like 
to 
> > get it into trunk.
> 
> Hi Paul.  I think it's time you checked in this patch.  It's had 
> ample time for 
> review even though I still haven't got around to going through it as 
> thouroughly as I would like to in an ideal world.  But it's not 
likeyou're a 
> drive-by contributor: you're around to improve it later if people find 
things 
> that need your input.  So just go for it.  Enough people agree the 
> functionality is good, and any deficiencies that remain by now must be 
minor.

Yes, I'm too cautious at times, better than too reckless :-)  Committed 
r20945.
 
> Some trivia I noticed:
> 
>    * main.c: Help text for "update" ends with a colon.
> 
>    * checkout_tests.py: whole content repeated in the patch file: take 
care 
> when applying the patch in case the unversioned file already exists,and 
check 
> you've "svn add"ed the file before committing.
> 
>    * checkout_tests.py: "'-m', 'Log message for new import'" is 
> silly (I'd just 
> write 'Import' or '').
> 
>    * checkout_tests.py: "Julian's scenario" -> proper brief description 
> (something like "Ensure that an import followed by a checkout in place 
works 
> perfectly")
> 
>    * Some spaces at end of lines (now we're talking Julian-level trivia)

Fixed all.

> > Julian - I know you wanted to see a new option used rather than 
--force, 
> > but looking back in the takeover threads I don't see a firm consensus 
on 
> > this.  If a new option is eventually what we decide on, I'll galdly 
change 
> > it later.
> 
> I'm fine with putting it in as "--force" for now.  I'd rather like it if 
it 
> could be renamed before it gets released, but that's for a separate 
> discussion.

Ok, leaving this for a future debate.

Thanks for all your help,

Paul B.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org