[jira] Commented: (PLUTO-601) Remove expensive object creation in PortletAppDescriptorServiceImpl

["Eric Dalquist (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PLUTO-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924199#action_12924199 ] 

Eric Dalquist commented on PLUTO-601:
-------------------------------------

My understanding was that the objects were thread-safe once created and configured. Since we don't ever leak references to them outside of the class I didn't think there would be a problem. I can change them back though.
The class loader code was changed because if we were able to create single instances of those classes we would always be within the Pluto (or portal's) context during creation. I'll change the XMLInputFactory and DocumentBuilderFactory back and be sure the correct classloader is used.

> Remove expensive object creation in PortletAppDescriptorServiceImpl
> -------------------------------------------------------------------
>
>                 Key: PLUTO-601
>                 URL: https://issues.apache.org/jira/browse/PLUTO-601
>             Project: Pluto
>          Issue Type: Improvement
>          Components: portlet container
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>             Fix For: 2.0.3, 2.1.0
>
>
> PortletAppDescriptorServiceImpl creates new JAXBContext, XMLInputFactory, DocumentBuilderFactory, and Pattern objects every time they are needed. All of these objects are thread-safe once created and configured and should only be created once at the class level and re-used for the life of the class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.