[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #650: Add a unique_ptr wrapper for rocksdb::Iterator

[GitBox <gi...@apache.org>]

PragmaTwice commented on PR #650:
URL: https://github.com/apache/incubator-kvrocks/pull/650#issuecomment-1163952006

   > > cool, but is it suitable to put this in `util`? actually we use many rocksdb utility methods that implement kvrocks logic. Maybe we can create a new file, we simply package some rocksdb methods in it, we also can easily change if we don't want to use methods provided by RocksDB, of course, can put the function of this PR into.
   > > And WDYT @git-hulk
   > 
   > Yes, it will be good to put the db util functions together, this also can resolve this comment: [#650 (comment)](https://github.com/apache/incubator-kvrocks/pull/650#discussion_r904428217)
   
   May I ask which header file those db utils are in? Is in `redis_db.h`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org