[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #755: Dispatch 1682: Augment parse tree lookup with a hash table

[GitBox <gi...@apache.org>]

ted-ross commented on a change in pull request #755:
URL: https://github.com/apache/qpid-dispatch/pull/755#discussion_r436977613



##########
File path: include/qpid/dispatch/iterator.h
##########
@@ -329,6 +329,11 @@ int qd_iterator_ncopy(qd_iterator_t *iter, unsigned char* buffer, int n);
  */
 unsigned char *qd_iterator_copy(qd_iterator_t *iter);
 
+/**

Review comment:
       Is there any reason that the const version shouldn't be the only version?  i.e. add const to the argument of the original function?

##########
File path: include/qpid/dispatch/iterator.h
##########
@@ -329,6 +329,11 @@ int qd_iterator_ncopy(qd_iterator_t *iter, unsigned char* buffer, int n);
  */
 unsigned char *qd_iterator_copy(qd_iterator_t *iter);
 
+/**

Review comment:
       In that case, don't make the change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org