You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/28 02:44:49 UTC

[GitHub] [skywalking] dmsolr commented on a change in pull request #3724: [test/plugin] container run.sh optimize

dmsolr commented on a change in pull request #3724: [test/plugin] container run.sh optimize
URL: https://github.com/apache/skywalking/pull/3724#discussion_r339387233
 
 

 ##########
 File path: test/plugin/containers/jvm-container/docker/run.sh
 ##########
 @@ -76,11 +76,11 @@ healthCheck http://localhost:12800/status
 healthCheck ${SCENARIO_HEALTH_CHECK_URL}
 
 echo "To visit entry service"
-curl -s --max-time 3 ${SCENARIO_ENTRY_SERVICE}
+curl -s --max-time 60 ${SCENARIO_ENTRY_SERVICE}
 
 Review comment:
   It is still a single thread to visit the mok-collector without retry. Increasing the timeout time why it could improve the success rate. Make tests more stable.
   There is no retry but will timeout in 60s. I think this change is necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services