You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/09/16 06:05:19 UTC
[GitHub] [incubator-yunikorn-web] chia7712 opened a new pull request #65: [YUNIKORN-849] The web can't get correct partition name from "/ws/v1/…
chia7712 opened a new pull request #65:
URL: https://github.com/apache/incubator-yunikorn-web/pull/65
…queues" since the key was changed from "partitionname" to "partitionName"
### What is this PR for?
the key was changed by https://github.com/apache/incubator-yunikorn-core/commit/160343fa2caacc9c825a3a92e717376a3f1c1f22.
Noted that this issue does not make web repo use new API. It just fix web to show the correct partition name.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-849
### How should this be tested?
### Screenshots (if appropriate)
**config**
```yaml
partitions:
- name: notdefault
nodesortpolicy:
type: binpacking
placementrules:
- name: provided
create: true
queues:
- name: root
properties:
application.sort.policy: stateaware
```
**Before**
<img width="487" alt="截圖 2021-09-16 下午2 04 18" src="https://user-images.githubusercontent.com/6234750/133558357-2a07dd78-4f3b-45bb-9150-5522c90b71cf.png">
**After**
<img width="490" alt="截圖 2021-09-16 下午2 01 32" src="https://user-images.githubusercontent.com/6234750/133558143-0704dd65-a10c-4494-b1d3-eb3fa28f3aa0.png">
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] chia7712 merged pull request #65: [YUNIKORN-849] The web can't get correct partition name from "/ws/v1/…
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #65:
URL: https://github.com/apache/incubator-yunikorn-web/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] chia7712 commented on pull request #65: [YUNIKORN-849] The web can't get correct partition name from "/ws/v1/…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #65:
URL: https://github.com/apache/incubator-yunikorn-web/pull/65#issuecomment-968552468
@wilfred-s Could I merge it myself after I rebase code to trigger QA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] wilfred-s commented on pull request #65: [YUNIKORN-849] The web can't get correct partition name from "/ws/v1/…
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #65:
URL: https://github.com/apache/incubator-yunikorn-web/pull/65#issuecomment-968536744
This has been lingering for a long time. @manirajv06: go ahead and commit this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] manirajv06 commented on pull request #65: [YUNIKORN-849] The web can't get correct partition name from "/ws/v1/…
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #65:
URL: https://github.com/apache/incubator-yunikorn-web/pull/65#issuecomment-921041689
Seems to be straight forward fix, but still good to ask @yangwwei to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] wilfred-s commented on pull request #65: [YUNIKORN-849] The web can't get correct partition name from "/ws/v1/…
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #65:
URL: https://github.com/apache/incubator-yunikorn-web/pull/65#issuecomment-968567656
yes sure, squash and merge from the Github web UI should handle it all for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org