You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "HsuehYi (via GitHub)" <gi...@apache.org> on 2026/10/20 07:47:56 UTC
[PR] Remove unused type: ignore comments in airflow-ctl [airflow]
HsuehYi opened a new pull request, #75193:
URL: https://github.com/apache/airflow/pull/75193
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
`mypy --warn-unused-ignores` — exposed to contributors as
`SHOW_UNUSED_MYPY_WARNINGS=true prek run mypy-airflow-ctl --all-files` — reports three
stale `# type: ignore` comments in `airflow-ctl`:
- `src/airflowctl/api/operations.py:221` — `[union-attr]`
- `src/airflowctl/api/operations.py:224` — `[union-attr]`
- `src/airflowctl/api/operations.py:228` — `[attr-defined]`
`execute_list()` leaves `data_model` untyped, so mypy already infers `Any` and these
suppressions no longer cover any error.
**Verification (run locally):**
- `prek run mypy-airflow-ctl --all-files` → passed
- the same check with `--warn-unused-ignores` → no findings left in `airflow-ctl`
- `breeze run --python 3.11 … mypy` (same invocation as the CI static-check job) → passed
- `ruff format` / `ruff check` → passed
The unused-ignore scan also lists 11 ignores in
`task-sdk/src/airflow/sdk/definitions/decorators/__init__.pyi`, but those only look unused
when the stub is followed from `airflow-ctl`; the task-sdk hook needs them, so they are
intentionally left untouched.
No runtime behaviour changes.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — OpenCode (DeepSeek V4.1 Flash Free)
Generated-by: OpenCode (DeepSeek V4.1 Flash Free) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused type: ignore comments in airflow-ctl [airflow]
Posted by "HsuehYi (via GitHub)" <gi...@apache.org>.
HsuehYi commented on PR #75193:
URL: https://github.com/apache/airflow/pull/75193#issuecomment-6288126366
Closing in favor of a fresh PR from the rebased branch.
---
Drafted-by: OpenCode (DeepSeek V4.1 Flash Free); reviewed by @HsuehYi before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused type: ignore comments in airflow-ctl [airflow]
Posted by "HsuehYi (via GitHub)" <gi...@apache.org>.
HsuehYi closed pull request #75193: Remove unused type: ignore comments in airflow-ctl
URL: https://github.com/apache/airflow/pull/75193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused type: ignore comments in airflow-ctl [airflow]
Posted by "HsuehYi (via GitHub)" <gi...@apache.org>.
HsuehYi commented on PR #75193:
URL: https://github.com/apache/airflow/pull/75193#issuecomment-6286778477
**The red checks are from `main`, not from this PR.**
All three failing jobs stop before running the changed code because the merge ref includes the invalid `uv.lock` currently on `main` (introduced by #73822):
```text
error: Failed to parse `uv.lock`
cause: Found duplicate package `pyvespa==1.2.9 @ registry+https://pypi.org/simple`
```
Confirmed in:
- **Airflow CTL tests (3.11)** — `uv run` fails right after creating the venv.
- **Shared distributions tests** — every test group fails at `uv sync` with the same parse error.
- **Build CI linux/amd64 image 3.11** — `uv sync --all-packages --frozen` fails, and the non-frozen fallback fails the same way.
This PR only removes three unused `# type: ignore` comments in `airflow-ctl`; it does not touch dependencies or `uv.lock`. The failure is tracked in #75195. I'll rebase and re-run CI once the lock fix lands — no action needed from reviewers on these failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org