[I] [Bug] [Service/Master] Global variables of sub-workflows not getting inherited by underlying sub-workflows [dolphinscheduler]

["MSerCegeka (via GitHub)" <gi...@apache.org>]

MSerCegeka opened a new issue, #17534:
URL: https://github.com/apache/dolphinscheduler/issues/17534

   ### Search before asking
   
   - [x] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   After the upgrade from 3.2.2 to 3.3.1, most of our workflows stopped working due to missing variables. This is due to global parameters from sub-workflows not being correctly set for use within their underlying sub-workflows.
   
   ### What you expected to happen
   
   When setting a global parameter in a sub-workflow, it's values should be propagated to all underlying sub-workflows.
   
   ### How to reproduce
   
   Create the following situation/workflow:
   - Workflow A calls Workflow B as a sub-workflow
   - Workflow B calls Workflow C as a sub-workflow
   - Workflow B defines a global variable $VALUE
   - Workflow C contains a shell script to print the $VALUE value
   - If you start execution from Workflow A, Workflow C does not receive the global $VALUE from Workflow B and prints nothing
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   3.3.1
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] [Service/Master] Global variables of sub-workflows not getting inherited by underlying sub-workflows [dolphinscheduler]

["SbloodyS (via GitHub)" <gi...@apache.org>]

SbloodyS closed issue #17534: [Bug] [Service/Master] Global variables of sub-workflows not getting inherited by underlying sub-workflows
URL: https://github.com/apache/dolphinscheduler/issues/17534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] [Service/Master] Global variables of sub-workflows not getting inherited by underlying sub-workflows [dolphinscheduler]

["LourierL (via GitHub)" <gi...@apache.org>]

LourierL commented on issue #17534:
URL: https://github.com/apache/dolphinscheduler/issues/17534#issuecomment-3342714835

   @SbloodyS
   this bug I reproduce in my local env,  in workflow of a->b->c which a has global param $A and b has global param $B, workflow c can only accept $A without $B.
   and I find it happens in SubWorkflowLogicTask.triggerNewSubWorkflow() which sub workflow only copy parent params without adding its own global param into it. the code which this bug happen in line 236-237
   `
   // todo: transport varpool and local params
    .startParamList(commandParam.getCommandParams())
   `
   I fix it in my local env, can I pull a request to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org