[GitHub] [ignite] RealZheka commented on a change in pull request #8041: IGNITE-13259 Removed default cache from REST APIs

[GitBox <gi...@apache.org>]

RealZheka commented on a change in pull request #8041:
URL: https://github.com/apache/ignite/pull/8041#discussion_r457034975



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/GridRestCommandHandlerAdapter.java
##########
@@ -26,8 +26,6 @@
  * Abstract command handler.
  */
 public abstract class GridRestCommandHandlerAdapter implements GridRestCommandHandler {
-    /** Used cache name in case the name was not defined in a request. */
-    protected static final String DFLT_CACHE_NAME = "default";

Review comment:
       I understand this, but this is pointless. It is not safe fallback, because there is no "default" cache. If you will try to use any API without a name you will receive the following error:
   
   _org.apache.ignite.IgniteCheckedException: Failed to find cache for given cache name: default_
   
   Better to replace it by the correctly formed error message that will point to the actual problem of the request. API document will be updated accordingly when PR will be merged.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org