[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1645: Remove non idiomatic `DataFusionError::into_arrow_external_error` in favor of From conversion

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1645:
URL: https://github.com/apache/arrow-datafusion/pull/1645#discussion_r790136002



##########
File path: datafusion/src/physical_plan/cross_join.rs
##########
@@ -331,8 +331,7 @@ fn build_batch(
             let scalar = ScalarValue::try_from_array(arr, left_index)?;
             Ok(scalar.to_array_of_size(batch.num_rows()))
         })
-        .collect::<Result<Vec<_>>>()
-        .map_err(|x| x.into_arrow_external_error())?;
+        .collect::<Result<Vec<_>>>()?;

Review comment:
       this is a pretty good exemplar of how this change makes the DataFusion codebase less confusing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org