You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/01 08:15:57 UTC

[GitHub] [incubator-kvrocks] tisonkun opened a new issue, #1148: Move VERSION file to src folder

tisonkun opened a new issue, #1148:
URL: https://github.com/apache/incubator-kvrocks/issues/1148

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   Move `VERSION` file to `src` folder, so that we have a tidy root layout.
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1148: Move VERSION file to src folder

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #1148:
URL: https://github.com/apache/incubator-kvrocks/issues/1148#issuecomment-1333696239

   Actually I have some doubt about this proposal. In my view, the `VERSION` file is not a source file, which seems not proper to be placed into the `src` directory.
   
   We can see the CI failed when someone try to move this file to `src` in #1149, whose reason is quite funny: there is a header named `version` in the C++ standard, and the move cause compiler to find wrong header and fail to compile.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun closed issue #1148: Move VERSION file to src folder

Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #1148: Move VERSION file to src folder
URL: https://github.com/apache/incubator-kvrocks/issues/1148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun commented on issue #1148: Move VERSION file to src folder

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #1148:
URL: https://github.com/apache/incubator-kvrocks/issues/1148#issuecomment-1333380405

   You should correspondingly update the build logic to fulfill VERSION information, including those in `x.py` and `CMakeList.txt`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org