[jira] [Commented] (KAFKA-9146) Add option to force delete members in stream reset tool

["feyman (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006658#comment-17006658 ] 

feyman commented on KAFKA-9146:
-------------------------------

Hi, [~mjsax]

I checked the code again with your guidance, per your comment:

_Frankly, I am not sure what bullet point (2) in the ticket description about dynamic membership means?_

=> I think the dynamic membership here is the non-static member, which is the member with group.instance.id=null, which is the traditional member before the concept static membership come in to the world , [~bchen225242] may correct me if I'm wrong~

 

For this task, I think :

1. maybe I should refactor org.apache.kafka.clients.admin.RemoveMembersFromConsumerGroupOptions#members of type Set<MemberIdentity> instead of  Set<MemberToRemove>, which will also support member.id to be specified for member removement

2.  In StreamsResetter, we have the choices on the implementation when we find some left-over members (if long session.timeout.ms provided), I'm not sure which is better

A) remove static/dynamic members silently, so the StreamResetter cmdline interface will not change

B) add some new cmdline args like "–forceDeleteMembers" to force delete the left-over members, if the arg is not explicitly set, then it just throw exception as current impl in kafka.tools.StreamsResetter#validateNoActiveConsumers

3. no change is needed on the server side – GroupCoordinator. etc

Do you have any concerns on 1 and preferences on 2 , [~bchen225242] [~mjsax] ? Thanks ! :)

 

> Add option to force delete members in stream reset tool
> -------------------------------------------------------
>
>                 Key: KAFKA-9146
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9146
>             Project: Kafka
>          Issue Type: Improvement
>          Components: consumer, streams
>            Reporter: Boyang Chen
>            Assignee: feyman
>            Priority: Major
>              Labels: newbie
>
> Sometimes people want to reset the stream application sooner, but blocked by the left-over members inside group coordinator, which only expire after session timeout. When user configures a really long session timeout, it could prevent the group from clearing. We should consider adding the support to cleanup members by forcing them to leave the group. To do that, 
>  # If the stream application is already on static membership, we could call directly from adminClient.removeMembersFromGroup
>  # If the application is on dynamic membership, we should modify adminClient.removeMembersFromGroup interface to allow deletion based on member.id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)