You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/01 19:38:38 UTC
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3458: HDDS-6764: EC: DN ability to create RECOVERING containers for EC reconstruction.
adoroszlai commented on code in PR #3458:
URL: https://github.com/apache/ozone/pull/3458#discussion_r887228323
##########
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/container/ContainerTestHelper.java:
##########
@@ -436,6 +441,7 @@ public static Builder newPutBlockRequestBuilder(Pipeline pipeline,
ContainerProtos.PutBlockRequestProto.Builder putRequest =
ContainerProtos.PutBlockRequestProto.newBuilder();
+ putRequest.setEof(true);
Review Comment:
Why is `eof=true` needed here? I think caller can set it later.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -471,7 +473,9 @@ public void validateContainerCommand(
}
State containerState = container.getContainerState();
- if (!HddsUtils.isReadOnly(msg) && containerState != State.OPEN) {
+ if (!HddsUtils.isReadOnly(msg)
+ && (containerState != State.OPEN
+ && containerState != State.RECOVERING)) {
Review Comment:
Would it make sense to add a method for handling OPEN and RECOVERING state the same way in specific cases? (I'm not sure what a good name for the method might be, though.)
##########
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto:
##########
@@ -270,6 +271,8 @@ message CreateContainerRequestProto {
repeated KeyValue metadata = 2;
optional ContainerType containerType = 3 [default = KeyValueContainer];
optional int32 replicaIndex = 4;
+ //optional LifeCycleState state = 5;
Review Comment:
Do we need to add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org