[GitHub] [doris] starocean999 commented on a diff in pull request #11335: [FIX](array)DCHECK error of array functions

[GitBox <gi...@apache.org>]

starocean999 commented on code in PR #11335:
URL: https://github.com/apache/doris/pull/11335#discussion_r933731907


##########
be/src/vec/functions/array/function_array_binary.h:
##########
@@ -39,7 +39,11 @@ class FunctionArrayBinary : public IFunction {
     DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
         DCHECK(is_array(arguments[0])) << arguments[0]->get_name();
         DCHECK(is_array(arguments[1])) << arguments[1]->get_name();
-        DCHECK(arguments[0]->equals(*arguments[1]))
+        auto left_nested_type = remove_nullable(

Review Comment:
   a p0 regression test case "select arrays_overlap([1,2,3,null], [3,4,5])" and "select array_intersect([1,2,3], [2,3,4,null])" would trigger the DCHECK because the data type is array<nullable<int>> and array<int>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org