You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by narendly <gi...@git.apache.org> on 2018/07/16 22:55:49 UTC

[GitHub] helix pull request #250: Modify TestGetLastScheduledTaskTimestamp for increa...

GitHub user narendly opened a pull request:

    https://github.com/apache/helix/pull/250

    Modify TestGetLastScheduledTaskTimestamp for increased stability

    …ability
    
    This test was experiencing an intermittent failure. No inherent faults of its own, but sometimes tasks were not being given enough resource/time to be scheduled and register the timestamp, which is expected depending on how fast the system is running. One area of improvement was that TestGetLastScheduledTaskTimestamp was using a long value 0 for invalid or unscheduled timestamps. It will use -1L from now on, which is the invalid flag TaskDriver uses.
    
    Changlist:
    1. Change the flag for invalid or unscheduled timestamps from 0 to -1L in TestGetLastScheduledTaskTimestamp

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/narendly/helix 1350766

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #250
    
----
commit 1e0247a7ef946f46e1fdf86f841b971321b45de0
Author: Hunter Lee <na...@...>
Date:   2018-07-16T22:54:06Z

    [HELIX-736] Modify TestGetLastScheduledTaskTimestamp for increased stability
    
    This test was experiencing an intermittent failure. No inherent faults of its own, but sometimes tasks were not being given enough resource/time to be scheduled and register the timestamp, which is expected depending on how fast the system is running. One area of improvement was that TestGetLastScheduledTaskTimestamp was using a long value 0 for invalid or unscheduled timestamps. It will use -1L from now on, which is the invalid flag TaskDriver uses.
    
    Changlist:
    1. Change the flag for invalid or unscheduled timestamps from 0 to -1L in TestGetLastScheduledTaskTimestamp

----


---

[GitHub] helix pull request #250: Modify TestGetLastScheduledTaskTimestamp for increa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/250


---