[GitHub] [phoenix] priyankporwal commented on a change in pull request #522: PHOENIX-5359: Remove (Global-Indexing)new coprocessors in CQSI#addCop…

[GitBox <gi...@apache.org>]

priyankporwal commented on a change in pull request #522: PHOENIX-5359: Remove (Global-Indexing)new coprocessors in CQSI#addCop…
URL: https://github.com/apache/phoenix/pull/522#discussion_r295563283
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ##########
 @@ -958,13 +960,19 @@ private void addCoprocessors(byte[] tableName, TableDescriptorBuilder builder, P
                             opts.put(NonTxIndexBuilder.CODEC_CLASS_NAME_KEY, PhoenixIndexCodec.class.getName());
                             IndexRegionObserver.enableIndexing(builder, PhoenixIndexBuilder.class, opts, priority);
                         }
+                        if (newDesc.hasCoprocessor(Indexer.class.getName())) {
 
 Review comment:
   Should we remove this before adding the new co-proc in the code-block right above? Since we are passing arounf the builder object to IndexRegionObserver it might be better to do cleanup first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services