You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 14:01:37 UTC

[GitHub] [arrow-datafusion] waitingkuo opened a new pull request, #3000: to_timestamp align with postgresql

waitingkuo opened a new pull request, #3000:
URL: https://github.com/apache/arrow-datafusion/pull/3000

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #2979 .
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   original to_timestamp assume time unit is nanosecond. this pr is to change it to second based (to align with postgresql's to_timestamp)
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ```to_timestamp``` use seconds instead of nanoseconds. a new ```to_timestamp_nanos``` expression is added that has the same behavior as the original to_timestamp
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   Yes. To migrate to new ```to_timestamp```. The original usage for ```to_timestamp(1_000_000_000)``` need to be modified to either ```to_timestamp(1)``` or ```to_timestamp_nanos(1_000_000_000)```
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   ```to_timestamp``` changed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] waitingkuo commented on pull request #3000: to_timestamp align with postgresql

Posted by GitBox <gi...@apache.org>.
waitingkuo commented on PR #3000:
URL: https://github.com/apache/arrow-datafusion/pull/3000#issuecomment-1201760815

   #2998 merged, all test passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] to_timestamp align with postgresql [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #3000: to_timestamp align with postgresql
URL: https://github.com/apache/arrow-datafusion/pull/3000


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] to_timestamp align with postgresql [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3000:
URL: https://github.com/apache/arrow-datafusion/pull/3000#issuecomment-1830641155

   Closing as this PR is over a year old. Please feel free to reopen it / rebase it if you plan to keep working on it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] waitingkuo commented on pull request #3000: to_timestamp align with postgresql

Posted by GitBox <gi...@apache.org>.
waitingkuo commented on PR #3000:
URL: https://github.com/apache/arrow-datafusion/pull/3000#issuecomment-1201248903

   pending due to #2998 . this make ```SELECT to_timestamp(a) FROM (SELECT to_timestamp(1) as a)A``` return wrong result


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org