[jira] Closed: (WICKET-1332) AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"

["Johan Compagner (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1332.
-----------------------------------

    Resolution: Fixed

i applied that last patch, can everybody test for the different browsers if it works now?

> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-1332
>                 URL: https://issues.apache.org/jira/browse/WICKET-1332
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.1
>            Reporter: Carlos Pita
>            Assignee: Johan Compagner
>             Fix For: 1.3.3
>
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
>  var choiceElementGroup = document.getElementById(markupid);
>  for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
>    var choiceElementList = choiceElementGroup.childNodes[x];   for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
>      if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
>        var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
>        if (tag == 'input') {
>          Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript);       }
>      }
>    }
>  }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.