[GitHub] [incubator-zipkin-reporter-java] adriancole opened a new issue #140: AsyncReporter should expose a thread factory

[GitBox <gi...@apache.org>]

adriancole opened a new issue #140: AsyncReporter should expose a thread factory
URL: https://github.com/apache/incubator-zipkin-reporter-java/issues/140
 
 
   currently we new up a thread, but this is a problem because it leads to distractions in log files such as in armeria. If we accept a thread factory, we can accomplish the desired result and also let framework hooks apply.
   
   ```
   2019-04-22 11:52:55.888  WARN 47949 --- [ender@19f9d595}] .a.c.t.RequestContextCurrentTraceContext : Attempted to propagate trace context, but no request context available. Did you forget to use RequestContext.contextAwareExecutor() or RequestContext.makeContextAware()?
   ```
   
   Specifically, we could fix this by adding `AsyncReporter.Builder.threadFactory(ThreadFactory)` and use it for our daemon thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org