You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by Regis Thomas <re...@nteligen.com> on 2021/01/25 18:15:23 UTC
RE: [GitHub] [incubator-daffodil] stevedlawrence commented on pull
request #481: ADD test for "%%" to bypass existing test for "%NL"
I made a commit then did a soft reset and re-committed (to put the description in the wiki suggested format), but it looks like the originally committed file reverted back to modified after the reset. I'll try again.
-----Original Message-----
From: GitBox <gi...@apache.org>
Sent: Monday, January 25, 2021 1:09 PM
To: commits@daffodil.apache.org
Subject: [GitHub] [incubator-daffodil] stevedlawrence commented on pull request #481: ADD test for "%%" to bypass existing test for "%NL"
stevedlawrence commented on pull request #481:
URL: https://usg02.safelinks.protection.office365.us/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-daffodil%2Fpull%2F481%23issuecomment-767008815&data=04%7C01%7Cregis.thomas%40nteligen.com%7Cb4c0e0d1b8444d3e1e7708d8c15c4f61%7C379c214c5c944e86a6062d047675f02a%7C0%7C0%7C637471949618763394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=x4PtiAjt2H2qioEdZ%2FFYIcZbSZiw2N0bsGvP%2FCgklVg%3D&reserved=0
Welcome!
Though, it looks like this pull request only includes ``.idea/`` files created by IntelliJ. Did you forget to add your changes to the scala files?
Also, as a rule, we don't commit files created by IDEs so we don't have to keep track of everyone's unique editor configurations. Instead, we recommend that you globally ignore those files so you don't accidentally commit them. The default git ignore files to do this are ``$XDG_CONFIG_HOME/git/ignore`` or ``$HOME/.config/git/ignore``. So you could just add ``.idea`` to one of those files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org