You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/13 12:34:00 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs

HyukjinKwon commented on a change in pull request #35193:
URL: https://github.com/apache/spark/pull/35193#discussion_r783916141



##########
File path: .github/workflows/notify_test_workflow.yml
##########
@@ -119,13 +138,13 @@ jobs:
                 status: status,
                 output: {
                   title: 'Test results',
-                  summary: '[See test results](' + runUrl + ')',
+                  summary: '[See test results](' + check_run_url + ')',
                   text: JSON.stringify({
                     owner: context.payload.pull_request.head.repo.owner.login,
                     repo: context.payload.pull_request.head.repo.name,
-                    run_id: runID
+                    run_id: run_id
                   })
                 },
-                details_url: runUrl,
+                details_url: actions_url,

Review comment:
       Actually I think we can even remove this but let me keep it as is for now (https://github.community/t/create-a-check-run-details-url-is-not-being-set/166002). This is currently just a metadata for now. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org