You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/09/27 15:52:51 UTC
svn commit: r819312 - in /ofbiz/branches/release09.04: ./
applications/product/src/org/ofbiz/product/promo/PromoServices.java
Author: jleroux
Date: Sun Sep 27 13:52:51 2009
New Revision: 819312
URL: http://svn.apache.org/viewvc?rev=819312&view=rev
Log:
"Applied fix from trunk for revision: 819275"
------------------------------------------------------------------------
r819275 | jleroux | 2009-09-27 10:57:11 +0200 (dim. 27 sept. 2009) | 1 ligne
Fix an issue when importing Promo Codes From File
------------------------------------------------------------------------
Modified:
ofbiz/branches/release09.04/ (props changed)
ofbiz/branches/release09.04/applications/product/src/org/ofbiz/product/promo/PromoServices.java
Propchange: ofbiz/branches/release09.04/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sun Sep 27 13:52:51 2009
@@ -1 +1 @@
-/ofbiz/trunk:765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770997,771073,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,777768,777792,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,808786-808787,808792,809141,810370,810438,810465,810807,810809,810814,810
832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,819282
+/ofbiz/trunk:765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770997,771073,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,777768,777792,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,808786-808787,808792,809141,810370,810438,810465,810807,810809,810814,810
832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,819275,819282
Modified: ofbiz/branches/release09.04/applications/product/src/org/ofbiz/product/promo/PromoServices.java
URL: http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/product/src/org/ofbiz/product/promo/PromoServices.java?rev=819312&r1=819311&r2=819312&view=diff
==============================================================================
--- ofbiz/branches/release09.04/applications/product/src/org/ofbiz/product/promo/PromoServices.java (original)
+++ ofbiz/branches/release09.04/applications/product/src/org/ofbiz/product/promo/PromoServices.java Sun Sep 27 13:52:51 2009
@@ -40,6 +40,8 @@
import java.sql.Timestamp;
import java.util.List;
import java.util.Map;
+import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
/**
* Promotions Services
@@ -112,11 +114,13 @@
LocalDispatcher dispatcher = dctx.getDispatcher();
// check the uploaded file
- byte[] wrapper = (byte[]) context.get("uploadedFile");
- if (wrapper == null) {
+ ByteBuffer fileBytes = (ByteBuffer) context.get("uploadedFile");
+ if (fileBytes == null) {
return ServiceUtil.returnError("Uploaded file not valid or corrupted");
}
+ String encoding = System.getProperty("file.encoding");
+ String file = Charset.forName(encoding).decode(fileBytes).toString();
// get the createProductPromoCode Model
ModelService promoModel;
try {
@@ -130,7 +134,7 @@
Map<String, Object> invokeCtx = promoModel.makeValid(context, ModelService.IN_PARAM);
// read the bytes into a reader
- BufferedReader reader = new BufferedReader(new StringReader(new String(wrapper)));
+ BufferedReader reader = new BufferedReader(new StringReader(file));
List<Object> errors = FastList.newInstance();
int lines = 0;
String line;