You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/01/26 19:08:12 UTC

[GitHub] [superset] justinpark opened a new pull request, #22876: fix(explore): Fix the test on AnnotationLayer

justinpark opened a new pull request, #22876:
URL: https://github.com/apache/superset/pull/22876

   ### SUMMARY
   This commit fixes the test regression due to #22453
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   - Before
   
   ```
   /home/runner/work/superset/superset/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx:159
     expect(await _testingLibrary.screen.findByText('Chart')).toBeInTheDocument();
   ```
   
   - After
   
   None
   
   ### TESTING INSTRUCTIONS
   CI
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] justinpark commented on pull request #22876: fix(explore): Fix the test on AnnotationLayer

Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #22876:
URL: https://github.com/apache/superset/pull/22876#issuecomment-1405539814

   hotfix already merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] justinpark closed pull request #22876: fix(explore): Fix the test on AnnotationLayer

Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark closed pull request #22876: fix(explore): Fix the test on AnnotationLayer
URL: https://github.com/apache/superset/pull/22876


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on pull request #22876: fix(explore): Fix the test on AnnotationLayer

Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #22876:
URL: https://github.com/apache/superset/pull/22876#issuecomment-1405532861

   Thanks @justinpark a fix was already merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org