You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/10 01:33:40 UTC

[GitHub] [spark] dongjoon-hyun commented on pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash

dongjoon-hyun commented on pull request #27601:
URL: https://github.com/apache/spark/pull/27601#issuecomment-706463993


   At that time, this was decided like the following. Given that, I guess we need some concrete reason like a performance number.
   > It's good to avoid hash collision, but I don't think it's a correctness issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org