You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2013/07/03 11:04:20 UTC
[jira] [Resolved] (HTTPCORE-345) Resource leak in
EntityAsyncContentProducer when produceContent is never called
[ https://issues.apache.org/jira/browse/HTTPCORE-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCORE-345.
----------------------------------------
Resolution: Fixed
Fix Version/s: 4.3-beta3
4.2.5
Tad, many thanks for reporting this problem. In fact, streaming entities should be closed regardless of the channel allocated internally by the producer. I applied your patches with some minor changes to SVN 4.2.x and trunk.
Please review / re-test
Oleg
> Resource leak in EntityAsyncContentProducer when produceContent is never called
> -------------------------------------------------------------------------------
>
> Key: HTTPCORE-345
> URL: https://issues.apache.org/jira/browse/HTTPCORE-345
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore, HttpCore NIO
> Affects Versions: 4.2.4
> Environment: Tested on Sun JDK 6 Linux 64 & Win 32
> Reporter: Tad Whitenight
> Fix For: 4.2.5, 4.3-beta3
>
> Attachments: EntityAsyncContentProducer.diff, TestHttpAsyncPrematureTermination.diff
>
>
> The HttpAsyncContentProducer javadoc does not mention that the produceContent method must be called.
> However, the close() method of EntityAsyncContentProducer assumes that the produceContent method was previously called.
> Quickly cancelled requests made to an HttpAsyncService can realize this scenario and thus leak resources backing response entities.
> I discovered this issue in 4.2.4, but am currently reproducing the issue with trunk.
> I'll attach a simplified test case shortly.
> A possible fix is to check if the channel was never created and close the underlying entity in this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org