You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yx-Yaoxaing (via GitHub)" <gi...@apache.org> on 2023/11/18 06:30:33 UTC
[PR] Resolving consumer beans from CGLIB proxy classes created by @Configuration [rocketmq-spring]
yx-Yaoxaing opened a new pull request, #596:
URL: https://github.com/apache/rocketmq-spring/pull/596
## What is the purpose of the change
Originally, when annotating a class with @Configuration, it couldn't be resolved as a RocketMQ consumer listener class. I changed the way annotations are parsed, allowing classes marked with @Configuration to be correctly identified as RocketMQ consumer listener classes. This is because, in our practice at the company, many people also prefer using @Configuration.
## Brief changelog
In the postProcessAfterInitialization() method of the RocketMQMessageListenerBeanPostProcessor message listener post-processor, I changed the annotation processing approach to:
RocketMQMessageListener ann = (RocketMQMessageListener) AnnotationUtils.findAnnotation(targetClass, RocketMQMessageListener.class);
This modification allows both @Configuration and @Service annotated classes to function as consumer listeners.
## Verifying this change
In production and actively deployed.
RocketMQMessageListener ann = AnnotationUtils.findAnnotation(targetClass, RocketMQMessageListener.class);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolving consumer beans from CGLIB proxy classes created by @Configuration [rocketmq-spring]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #596:
URL: https://github.com/apache/rocketmq-spring/pull/596#issuecomment-5129799513
⚠️ **Merge conflict detected**
This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
```bash
git fetch origin
git checkout master
git rebase origin/main
# resolve conflicts, then:
git push --force-with-lease
```
This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
---
*Automated notification by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org