[GitHub] [apisix] Sn0rt commented on a diff in pull request #9455: fix: allow serverless plugin empty user-agent

["Sn0rt (via GitHub)" <gi...@apache.org>]

Sn0rt commented on code in PR #9455:
URL: https://github.com/apache/apisix/pull/9455#discussion_r1192031204


##########
apisix/plugins/serverless/generic-upstream.lua:
##########
@@ -35,6 +35,7 @@ return function(plugin_name, version, priority, request_processor, authz_schema,
             function_uri = {type = "string"},
             authorization = authz_schema,
             timeout = {type = "integer", minimum = 100, default = 3000},
+            use_default_user_agent = {type = "boolean", default = true},

Review Comment:
   sounds reasonable. the reason to set the default value as true, which is the original logic of the program.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org