You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/18 17:30:15 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request, #4195: Cxf-soap tests: Refactor and split
ppalaga opened a new pull request, #4195:
URL: https://github.com/apache/camel-quarkus/pull/4195
Fix #4171
Replaces #4172 and #4187 (adding the suggestions mentioned in https://github.com/apache/camel-quarkus/pull/4187#issuecomment-1282564510 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4195: Cxf-soap tests: Refactor and split
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on code in PR #4195:
URL: https://github.com/apache/camel-quarkus/pull/4195#discussion_r999086770
##########
integration-test-groups/cxf-soap/cxf-soap-client/src/main/resources/wsdl/CalculatorService.wsdl:
##########
@@ -0,0 +1,248 @@
+<?xml version="1.0" ?><wsdl:definitions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" xmlns:tns="http://www.jboss.org/eap/quickstarts/wscalculator/Calculator" xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:ns1="http://schemas.xmlsoap.org/soap/http" name="CalculatorService" targetNamespace="http://www.jboss.org/eap/quickstarts/wscalculator/Calculator">
+<!--
Review Comment:
it's the same in XML files, ignore my comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #4195: Cxf-soap tests: Refactor and split
Posted by GitBox <gi...@apache.org>.
ppalaga merged PR #4195:
URL: https://github.com/apache/camel-quarkus/pull/4195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4195: Cxf-soap tests: Refactor and split
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4195:
URL: https://github.com/apache/camel-quarkus/pull/4195#issuecomment-1283682885
> this needs backporting to 2.13.x?
Yes please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4195: Cxf-soap tests: Refactor and split
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4195:
URL: https://github.com/apache/camel-quarkus/pull/4195#issuecomment-1283675528
@ppalaga I'm guessing this needs backporting to 2.13.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4195: Cxf-soap tests: Refactor and split
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on code in PR #4195:
URL: https://github.com/apache/camel-quarkus/pull/4195#discussion_r999072197
##########
integration-test-groups/cxf-soap/cxf-soap-client/src/main/resources/wsdl/CalculatorService.wsdl:
##########
@@ -0,0 +1,248 @@
+<?xml version="1.0" ?><wsdl:definitions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" xmlns:tns="http://www.jboss.org/eap/quickstarts/wscalculator/Calculator" xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:ns1="http://schemas.xmlsoap.org/soap/http" name="CalculatorService" targetNamespace="http://www.jboss.org/eap/quickstarts/wscalculator/Calculator">
+<!--
Review Comment:
Is there a reason why this is not the first line of the file ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org