You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2023/05/17 15:55:44 UTC

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4764: [hotfix][kafka] Fix the problem that the partition information cannot be obtained when kafka is restored

TyrantLucifer commented on code in PR #4764:
URL: https://github.com/apache/incubator-seatunnel/pull/4764#discussion_r1196739655


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/flow/SourceFlowLifeCycle.java:
##########
@@ -177,7 +177,7 @@ public void requestSplit() {
                             enumeratorTaskAddress)
                     .get();
         } catch (InterruptedException | ExecutionException e) {
-            log.warn("source request split failed [{}]", e);
+            log.warn("source request split failed.", e);

Review Comment:
   Why change it?



##########
.gitignore:
##########
@@ -48,4 +48,5 @@ test.conf
 spark-warehouse
 *.flattened-pom.xml
 
-seatunnel-examples
\ No newline at end of file
+seatunnel-examples

Review Comment:
   revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org