You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2012/09/18 19:52:51 UTC
[9/14] android commit: Remove TODO comment about calling webView from
non-ui thread.
Remove TODO comment about calling webView from non-ui thread.
I tried it and it turned out to be a bit slower instead of faster.
Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/9e3e7e18
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/9e3e7e18
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/9e3e7e18
Branch: refs/heads/master
Commit: 9e3e7e1820a7c96bb9b9ec45a20137b4380170be
Parents: 18893bf
Author: Andrew Grieve <ag...@chromium.org>
Authored: Tue Sep 11 14:51:38 2012 -0400
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Tue Sep 18 13:24:37 2012 -0400
----------------------------------------------------------------------
.../org/apache/cordova/NativeToJsMessageQueue.java | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/9e3e7e18/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/NativeToJsMessageQueue.java b/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
index 807e87e..8e022b4 100755
--- a/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
+++ b/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
@@ -303,8 +303,6 @@ public class NativeToJsMessageQueue {
webView.setNetworkAvailable(true);
}
public void onNativeToJsMessageAvailable() {
- // TODO(agrieve): consider running this *not* on the main thread, since it just
- // sends a message under-the-hood anyways.
cordova.getActivity().runOnUiThread(runnable);
}
}